Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more headers for caching #53

Closed
wants to merge 1 commit into from
Closed

Added more headers for caching #53

wants to merge 1 commit into from

Conversation

dylanratcliffe
Copy link
Member

No description provided.

Copy link

github-actions bot commented Jan 18, 2024

mapped Expected Changes

updated cloudfront-response-headers-policy › 8ed09a88-177f-4f37-a844-66b7b54a7cda
--- current
+++ planned
@@ -4,6 +4,8 @@
       access_control_allow_headers:
         - items:
             - X-Example-Header
+            - X-Session
+            - X-Trace-ID
       access_control_allow_methods:
         - items:
             - GET

Blast Radius

items Items edges Edges
459 465

Open in Overmind

warning Risks

medium Cache Behavior Impact on CloudFront Distribution [Medium]

The update in access_control_allow_headers by adding X-Session and X-Trace-ID headers could affect caching behavior of the CloudFront Distribution 540044833068.cloudfront-distribution.E15V1JM5GZXBKB. If the application logic relies on these headers for caching, their addition without corresponding application code changes may lead to unintended cache hits or misses, potentially serving stale content or reducing cache efficiency.

medium Disruption to CORS Policy [Medium]

The automatic addition of headers to the aws_cloudfront_response_headers_policy named headers-policy (GloballyUniqueName: 540044833068.cloudfront-response-headers-policy.8ed09a88-177f-4f37-a844-66b7b54a7cda) can disrupt the current CORS configuration. If the application relies on a strict CORS policy allowing only specific headers, adding new headers could either open up more than intended or cause requests to be blocked if not handled by the application logic.

medium Inadequate Validation of New Headers [Medium]

New headers X-Session and X-Trace-ID are introduced without evidence of validation in the existing infrastructure. Without proper validation that the application or other services correctly use these headers, functionality could be affected, leading to potential errors or misbehavior in the services that depend on header data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant